Skip to content

Upgrade Parcel and replace cssnano with Parcel CSS #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 9, 2022
Merged

Upgrade Parcel and replace cssnano with Parcel CSS #2776

merged 3 commits into from
Feb 9, 2022

Conversation

devongovett
Copy link
Member

Upgrades Parcel to 2.2.1, and replaces cssnano with @parcel/css, the new CSS minifier we've been working on. This will be the default in Parcel soon, but I'd like to try it out. Eventually, we will also replace PostCSS. I have a POC for that, but it will be done separately.

@adobe-bot
Copy link

Build successful! 🎉

@snowystinger
Copy link
Member

I'll run chromatic on this a little later. If anyone else wants to, run it on main first, then run it here

@devongovett
Copy link
Member Author

Chromatic won't be helpful as this only affects the docs.

@snowystinger
Copy link
Member

acht, yep, well, we could run the docs differ then

ktabors
ktabors reviewed Jan 27, 2022
View reviewed changes
Copy link
Member

@ktabors ktabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran docs differ and shared all relevant data with Devon. No changes needed.

ktabors
ktabors reviewed Jan 27, 2022
View reviewed changes
Copy link
Member

@ktabors ktabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine to me.

I'm curious about the scripts where you removed the cssnano.config.js and didn't add anything else.

snowystinger
snowystinger previously approved these changes Feb 1, 2022
View reviewed changes
@ross-pfahler
Copy link
Collaborator

how did the CSS size turn out?

ktabors
ktabors previously approved these changes Feb 2, 2022
View reviewed changes
@devongovett devongovett dismissed stale reviews from ktabors and snowystinger via 281da4b February 8, 2022 23:45
@adobe-bot
Copy link

Build successful! 🎉

@devongovett
Copy link
Member Author

@ross-pfahler

Before:

watchModals.46c88271.css                                  406.74 KB     7.18s
useSearchAutocomplete.f17b0707.css                         77.21 KB     7.43s
SearchAutocomplete.1b13cdfe.css                            120.6 KB     7.17s
Calendar.d90dbca7.css                                     368.52 KB     7.17s
ColorField.1af90b7c.css                                    12.44 KB     7.33s
DateField.b2662e59.css                                     44.88 KB     7.17s
Dialog.70c9c899.css                                        17.64 KB     7.44s
SearchWithin.5d7c5f9f.css                                   2.41 KB     7.19s
error.305ce146.css                                          2.24 KB     7.42s
index.2b12e215.css                                         96.33 KB     7.39s

Total                                                    1149.01 KB

After:

watchModals.8a1bde16.css                                   402.9 KB     5.85s
useSearchAutocomplete.00e4d326.css                         78.94 KB     5.60s
SearchAutocomplete.362bbbd6.css                           121.12 KB     5.47s
Calendar.40b790a7.css                                     364.64 KB     5.47s
ColorField.0a184508.css                                    12.24 KB     6.47s
DateField.a83ec3f0.css                                     46.43 KB     5.46s
Dialog.6667adfb.css                                        17.01 KB     4.96s
SearchWithin.a6155dca.css                                   2.29 KB     5.19s
error.d02644a9.css                                          2.08 KB     4.98s
index.58807432.css                                         97.48 KB     5.45s

Total                                                    1145.13 KB (-3.88 KB)

@devongovett devongovett merged commit b2abc5d into main Feb 9, 2022
@devongovett devongovett deleted the parcel-css branch February 9, 2022 00:07
@devongovett devongovett mentioned this pull request Feb 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktabors ktabors ktabors left review comments

@snowystinger snowystinger snowystinger left review comments

@dannify dannify Awaiting requested review from dannify

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devongovett @adobe-bot @snowystinger @ross-pfahler @ktabors